Skip to content

75,76,77 #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kingofclubstroyDev wants to merge 3 commits into
base: master
Choose a base branch
from
Open

75,76,77 #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
588e7dc
75,76,77
kingofclubstroyDev Mar 3, 2026
186a9ce
fix
kingofclubstroyDev Mar 3, 2026
ad6fab4
fix
kingofclubstroyDev Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions client/library/library/audits/sevenSeas-75.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<page
clientName="Seven Seas"
reportDate="March 3rd, 2026"
auditTitle="Seven Seas A-75"
auditVersion="1.0.0"
repoUrl="https://github.com/Veda-Labs/boring-vault"
layout="/library/audits/_layout.html"
customRepoInfo
issueSummaryFormat="table"
>

<content-for name="schedule">
The audit was performed by the Macro security team on February 25th, 2025.
</content-for>

<content-for name="spec">
<ul>
<li>Discussions with the {{page.clientName}} team.</li>
<li>Available documentation in the repository.</li>
</ul>
</content-for>

<content-for name="repo-info">
<ul>
<li class="break-words break-all">
<b>One Inch V6 decoder (from <a href="https://github.com/Veda-Labs/boring-vault/pull/610">PR 610</a>)</b> </br>
Commit Hash: <code>260b62e882ebe8f376fe4e3c44b5602c4720b746</code>
<template type="file-hashes">
61fe6015ebb845b6f22be0dbe50e72fc41869972f2b86bc8ea34e0867467376c src/base/DecodersAndSanitizers/Protocols/OneInchDecoderAndSanitizer.sol
964cdaa88caf8d47365e3fb31389fbe0d4d07f9839c8188c8f01662286e74f55 src/base/DecodersAndSanitizers/Protocols/OneInchOwnedDecoderAndSanitizer.sol
</template>
</li>
</ul>
</content-for>
</page>
34 changes: 34 additions & 0 deletions client/library/library/audits/sevenSeas-76.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<page
clientName="Seven Seas"
reportDate="March 3rd, 2026"
auditTitle="Seven Seas A-76"
auditVersion="1.0.0"
repoUrl="https://github.com/Veda-Labs/boring-vault"
layout="/library/audits/_layout.html"
customRepoInfo
issueSummaryFormat="table"
>

<content-for name="schedule">
The audit was performed by the Macro security team on February 25th, 2025.
</content-for>

<content-for name="spec">
<ul>
<li>Discussions with the {{page.clientName}} team.</li>
<li>Available documentation in the repository.</li>
</ul>
</content-for>

<content-for name="repo-info">
<ul>
<li class="break-words break-all">
<b>ArcticArchitectureLens (from <a href="https://github.com/Veda-Labs/boring-vault/pull/601">PR 601</a>)</b> </br>
Commit Hash: <code>99b03fdad8538060a0d3aaf4728cd4ea4444a902</code>
<template type="file-hashes">
b7ad3b6003749fa5f8a28778111a664155235e23d1f94f548dc28d1634021ab3 src/helper/ArcticArchitectureLens.sol
</template>
</li>
</ul>
</content-for>
</page>
34 changes: 34 additions & 0 deletions client/library/library/audits/sevenSeas-77.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<page
clientName="Seven Seas"
reportDate="March 3rd, 2026"
auditTitle="Seven Seas A-77"
auditVersion="1.0.0"
repoUrl="https://github.com/Veda-Labs/boring-vault"
layout="/library/audits/_layout.html"
customRepoInfo
issueSummaryFormat="table"
>

<content-for name="schedule">
The audit was performed by the Macro security team on February 25th, 2025.
</content-for>

<content-for name="spec">
<ul>
<li>Discussions with the {{page.clientName}} team.</li>
<li>Available documentation in the repository.</li>
</ul>
</content-for>

<content-for name="repo-info">
<ul>
<li class="break-words break-all">
<b> <a href="https://github.com/Veda-Labs/boring-vault/blob/24c42f7ccb42ad535446605808cfd163d2c94ea2/src/base/Roles/BoringQueue/BoringOnChainQueueWithTracking.sol">BoringOnChainQueueWithTracking</a></b> </br>
Commit Hash: <code>24c42f7ccb42ad535446605808cfd163d2c94ea2</code>
<template type="file-hashes">
d3c8d761d8fb929834cc44da9277d48967cc95bf8c657d96d71441c94a7bad57 src/base/Roles/BoringQueue/BoringOnChainQueueWithTracking.sol
</template>
</li>
</ul>
</content-for>
</page>
Empty file added content/collections/public/sevenSeas-75-issues.html
View file
Open in desktop
Empty file.
16 changes: 16 additions & 0 deletions content/collections/public/sevenSeas-76-issues.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<item>
<field name="topic">User Experience</field>
<field name="impact">low</field>
<field name="status">fixed</field>
<field name="commit">f05bdea530101fcb904b83ddd2f8cef1dc843a0e</field>
<field name="content">
## [Q-1] Preview withdraw should return amount of withdrawable assets

When calling [previewWithdrawal()](https://github.com/Veda-Labs/boring-vault/blob/99b03fdad8538060a0d3aaf4728cd4ea4444a902/src/helper/ArcticArchitectureLens.sol#L214-L245) or [previewInstantWithdrawal()](https://github.com/Veda-Labs/boring-vault/blob/99b03fdad8538060a0d3aaf4728cd4ea4444a902/src/helper/ArcticArchitectureLens.sol#L275-L321), a bool `notEnoughWithdrawableAssets` is returned if the assets requested are available to withdraw. However, this doesn’t give information to users on how much could be withdrawn, just that their request exceeds what is available.

**Remediations to Consider**

Rather than return a bool, return the assets that can be withdrawn to allow requests to be adjusted more easily to withdraw what is available.
</field>
</item>

Empty file added content/collections/public/sevenSeas-77-issues.html
View file
Open in desktop
Empty file.