fix: migration bug#194
Open
lima-limon-inc wants to merge 2 commits intomainfrom
Open
Conversation
lima-limon-inc
force-pushed
the
fabrizioorsi/i193-fix-migration
branch
2 times, most recently
from
2257849 to
9cbc701
Compare
lima-limon-inc
force-pushed
the
fabrizioorsi/i193-fix-migration
branch
from
954d200 to
a4df986
Compare
lima-limon-inc
added
the
check:install
Collaborator
|
@lima-limon-inc Is this ready for final review/merge? |
Collaborator
Author
It is ^_^. One small caveat though: there currently is an uninstall-related bug that I'm fixing over on #196 which causes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
midenup updateperformed a migration when an upstream channel contained theMigrationtag. However, the migration was triggered even when the channel had already been migrated.This PR fixes this issue by only triggering a migration if the current channel's name matches the
Migration'sold_channelfield.Additionally, the code was simplified a bit:
PartialEq for Channelwas removed since it was a bit too side-effect-y and was only used when finding a localChannel's upstream counterpart. Similarly,fn migrated_intowas also removed since.find_upstream_counterpartfunction.