chore(telemetry): client.address should be the resolved client address#2032
Merged
Mirko-von-Leipzig merged 3 commits intomainfrom May 4, 2026
Merged
chore(telemetry): client.address should be the resolved client address#2032Mirko-von-Leipzig merged 3 commits intomainfrom
client.address should be the resolved client address#2032Mirko-von-Leipzig merged 3 commits intomainfrom
Conversation
Comment on lines
+70
to
+72
| if let Ok(ip) = SmartIpKeyExtractor.extract(request) { | ||
| span.set_attribute("client.address", ip); | ||
| } else if let Some(addr) = remote_addr { |
Collaborator
Author
There was a problem hiding this comment.
Unfortunately no port available without performing the header parsing ourselves, which I don't think is worth it.
Mirko-von-Leipzig
added
the
no changelog
sergerad
approved these changes
May 3, 2026
kkovaacs
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment its the direct client (which is often a reverse proxy).