fix: correctly propagate the current span to blocking tasks#2061
Merged
fix: correctly propagate the current span to blocking tasks#2061
Conversation
kkovaacs
added
the
no changelog
Mirko-von-Leipzig
approved these changes
May 7, 2026
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Thanks. Should we consider adding the tokio methods to the disallowed list in clippy.toml? I think one can still #[allow] them in cases where needed..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes that were moving blocking / CPU intensive calls to blocking tasks were not propagating the tracing span correctly.
This PR fixes span propagation by introducing a set of helper functions for spawning blocking tasks that do span propagation correctly.