Draft
Conversation
- Stop forcing reviewers to fabricate findings; nits/notes are advisory - Require explicit APPROVE:/CLEAN: verdict (not just absence of BLOCK:) - Use repo root in lint/test hooks so they work from subdirectories - Add branch guards to rebase agent (skip protected branches) - Pass --allowedTools to review agents for Bash/Read access - Add per-project lessons link to CLAUDE.md - Remove dangling .claude/skills symlink Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> fix: CI monitor needs --allowedTools and effort: medium to actually execute
mmagician
added
the
no changelog
Adds a PostToolUse hook that fires after PR creation and spawns a changelog-manager agent to classify the diff. The agent determines whether a CHANGELOG.md entry or "no changelog" label is needed, and feeds actionable instructions back to the main agent via exit code 2. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mmagician
added
the
pr-from-maintainers
* Improve Claude setup based on NTL battle-testing Consolidated pre-push hook: - Merged pre-push-test.sh into pre-push-review.sh (tests run first, then reviewers only if tests pass - saves reviewer tokens on broken code) - Severity-based blocking: nits and notes don't block push, only Critical/Important/Warning findings do - Proper diff base resolution: tries upstream, falls back to default branch via gh, then HEAD~1 - Handles reviewer crashes gracefully (empty/malformed output = block) - Escape hatch: SKIP_PRE_PUSH=1 Input guards on all hooks: - Each hook validates the command matches before acting (defense in depth against settings.json filter regressions) Improved settings.json: - Removed separate pre-push-test.sh entry (now in pre-push-review.sh) - Added proper `if` filter on pre-pr-draft.sh (was firing on all Bash) - Removed post-pr-create-ci-monitor.sh (superseded) Lessons system: - Added .claude/lessons.md for codifying review feedback - Added .claude/commands/codify-lesson.md slash command - Updated CLAUDE.md to reference in-repo lessons file instead of global ~/.claude path Agent improvements: - Code reviewer and security reviewer use gh-based default branch resolution instead of hardcoded branch names Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Address review: remove guards, split hooks, drop lessons - Remove input guards from all hooks (boilerplate, unclear value) - Restore pre-push-test.sh as separate hook (keep tests and reviews conceptually separate per review feedback) - Remove lessons.md and codify-lesson.md (use SKILLS.md instead) - Revert CLAUDE.md lessons reference - Keep: severity-based blocking, diff base resolution, crash handling, proper if filters, agent branch resolution via gh Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Adding new lines at the end of the file * Removing unecessary code from post-pr-create-changelog.sh * removing code from pre-pr-draft.sh * remove escape hatch from pre-pr-draft.sh * simplifying pre-pr-draft.sh * removing escape hatch and default org repo from pre-push-review.sh --------- Co-authored-by: Claude (Opus) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desired workflow:
make lintmake test--draftmodeCHANGELOG.mdexists; if yes, proceeds; if not, determines whether it should add an entry or ano changeloglabel - the main agent takes care of this.The goal is to codify our shared knowledge into a set of actionable artifacts.
TODOs: