refactor(note): rename recipient builder procedures#2878
Merged
PhilippGackstatter merged 1 commit into0xMiden:nextfrom May 7, 2026
Merged
refactor(note): rename recipient builder procedures#2878PhilippGackstatter merged 1 commit into0xMiden:nextfrom
PhilippGackstatter merged 1 commit into0xMiden:nextfrom
Conversation
giwaov
force-pushed
the
issue-2875-rename-recipient-builders
branch
from
9fa7636 to
57161a0
Compare
Contributor
|
@giwaov Could you fix the CI failures? |
Contributor
Author
working on it sir |
giwaov
force-pushed
the
issue-2875-rename-recipient-builders
branch
from
57161a0 to
329099f
Compare
PhilippGackstatter
approved these changes
May 7, 2026
Contributor
PhilippGackstatter
left a comment
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2875.
Renames the note recipient helpers so the side effect is clearer:
note::build_recipient_hash->note::compute_recipientnote::build_recipient->note::compute_and_store_recipientThe second procedure also writes the recipient preimages into advice inputs, so the new name makes that behavior harder to miss.
I updated the MASM call sites, related test names/comments, and the changelog.
Checked with
git diff --check. I also tried the focusedmiden-testingfilters, but the local build is still blocked inmiden-core-libwithproject 'miden-core' is missing its manifest path.