fix(web-client): align NoteType enum discriminants with miden_client::note::NoteType#22
Open
WiktorStarczewski wants to merge 1 commit into
Open
fix(web-client): align NoteType enum discriminants with miden_client::note::NoteType#22WiktorStarczewski wants to merge 1 commit into
WiktorStarczewski wants to merge 1 commit into
Conversation
…t::note::NoteType via compile-time assertions Migrated from 0xMiden/miden-client#2134 (author: AlexWaker) as part of the web-sdk split. Original PR: 0xMiden/miden-client#2134
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated from miden-client#2134 (author: @AlexWaker) as part of the web-sdk split (web/WASM components moved out of miden-client into this dedicated repo — see miden-client #1992 / #2135).
Summary (per the original PR)
NoteTypeenum's JS-facing discriminant values (Private = 0b10,Public = 0b01) aligned withmiden_client::note::NoteType.wasm_bindgenrequires exported C-style enum discriminants to be numeric literals, so the web-client enum keeps literal values and verifies them against the native enum at compile time.Keep these masks in sync with miden-protocol/src/note/note_type.rscomment now that the static asserts enforce the invariant.Context
Closes the web-sdk side of miden-client#1749. The CLI-side change (
bin/miden-cli/src/commands/notes.rs) stays on the original miden-client PR.