feat(transport): resendPrivateNoteById() for post-failure recovery#26
Open
WiktorStarczewski wants to merge 3 commits into
Open
feat(transport): resendPrivateNoteById() for post-failure recovery#26WiktorStarczewski wants to merge 3 commits into
WiktorStarczewski wants to merge 3 commits into
Conversation
Migrated from 0xMiden/miden-client#2061 (author: WiktorStarczewski) as part of the web-sdk split. Original PR: 0xMiden/miden-client#2061
4 tasks
Repoint workspace dep at miden-client#2061's branch so CI can compile against `Client::resend_private_note_by_id()` (added by that PR, not yet released). Revert before merge — see PR description for the merge sequence.
WiktorStarczewski
added
the
no changelog
WiktorStarczewski
added a commit
that referenced
this pull request
Apr 30, 2026
Now that miden-client#1835's wiktor-storekeys branch has been merged with miden-client@dab6cf7b (the same snapshot of next that web-sdk currently pins), the dep retarget that #23/#25/#26/#31 use works for this PR too. Local 'cargo check --workspace --target wasm32-unknown-unknown' is clean (was 23 errors before the upstream merge, due to the alpha-protocol mismatch the PR description mentions). Revert before merge — see PR description merge gate.
This was referenced Apr 30, 2026
…op manual dep retarget Brings auto-patch infra in. Cargo.toml + Cargo.lock now match main verbatim; the 'Client PR: #2061' marker on the PR description drives the runtime dep injection.
|
🔗 Linked client PR:
This run is testing against the linked PR's head. The published artifact will use the canonical Local-dev parity: |
WiktorStarczewski
added a commit
to 0xMiden/miden-client
that referenced
this pull request
May 4, 2026
When a private note send's transport step fails (network error, service outage) after the on-chain tx committed, the sender's asset is consumed but the recipient can never discover the note — private notes have no on-chain details, only the commitment. Without a resend primitive the asset is effectively lost. Adds resend_private_note_by_id(note_id, address) on the Rust Client. Looks up the output note from the local store, reconstructs the full Note, and re-hands it to the transport layer. Consumers (wallet, external apps) can now surface a retry flow when they observe a transport failure, or run a background loop that retries pending transports. The web-client / WASM JS bindings live in 0xMiden/web-sdk#26 — split out per the post-#1992 repo layout.
WiktorStarczewski
added a commit
to 0xMiden/miden-client
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client PR: #2061
Migrated from miden-client#2061 as part of the web-sdk split (web/WASM components moved out of miden-client into this dedicated repo — see miden-client #1992 / #2135).
Summary (per the original PR)
Adds a
resendPrivateNoteById()method to the WebClient note transport, allowing post-failure recovery by re-sending a previously created private note by its ID. The CLI/Rust-only changes from the original PR remain on miden-client#2061.