ci(next): publish react-sdk and vite-plugin alongside web-client on release#36
Merged
WiktorStarczewski merged 3 commits intoApr 28, 2026
Merged
Conversation
… (next) Same fix as the main-branch PR (#35), adapted to the napi-augmented release workflow on next: - New scripts: check-react-sdk-version-release.sh + check-vite-plugin-version-release.sh (identical to main-side; also part of #35). - check-version job now computes should_publish + current_version outputs for all three packages. - publish job runs whenever ANY of the three needs to ship. Each step is individually gated so a release that bumps only one package republishes only that one. The Node.js platform packages (node-sdk-*) remain tied to the web-client publish so optionalDependencies versions match. - skipped job fires only when all three are not-publishing.
Previously the release-publish gate skipped the entire publish when the release tag's last commit didn't touch the package's package.json. That made the bump commit semantically required to be HEAD of the release tag, which is silly — the question is just whether the version is already on the registry. Switch all three scripts (web-client, react-sdk, vite-plugin) to query `npm view <pkg>@<version>` and publish iff that version isn't there yet. Removes the spurious dependency on commit ordering relative to the tag.
Match the secret name to the cargo env var (and to miden-node's convention) so the publish-crates workflow picks up the org-managed secret without an indirection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to #35 (the main-branch fix), adapted to next's napi-augmented release workflow.
Why this is needed on next too
The release workflow on
nextis more complex thanmain's — it builds and publishes Node.js native binaries (@miden-sdk/node-darwin-arm64,@miden-sdk/node-darwin-x64,@miden-sdk/node-linux-x64-gnu) that came in via the PR #13 sync. But it has the same gap as main: it only publishes@miden-sdk/miden-sdk, never@miden-sdk/reactor@miden-sdk/vite-plugin. End users runningnpm install @miden-sdk/reactafter a v0.15.x release would still be stuck on whatever thenextdist-tag points at.Changes
scripts/check-react-sdk-version-release.sh+scripts/check-vite-plugin-version-release.sh(identical files).check-versionjob now also computesreact_should_publish/vite_should_publishoutputs.publishjob runs whenever any of the three packages needs to ship; each step is individually gated so a release that bumps only one package republishes only that one.node-sdk-*) remain tied to the web-client publish — they only ship when web-client itself ships, so theoptionalDependenciesversions on web-client'spackage.jsonalways match a real published platform-binary version.skippedjob now fires only when all three are not-publishing (instead of just web-client).Why two PRs
next and main have meaningfully different release workflows (next has napi platform builds; main doesn't). I'd rather fix each independently than make either land first conditionally. When PR #32 (
next → mainfor v0.15.0) merges, main will inherit next's full workflow including this fix.