Skip to content

fix(ci): normalize PR state to lowercase in auto-patch (next)#68

Merged
WiktorStarczewski merged 1 commit into
nextfrom
wiktor/auto-patch-state-case-fix-next
Apr 30, 2026
Merged

fix(ci): normalize PR state to lowercase in auto-patch (next)#68
WiktorStarczewski merged 1 commit into
nextfrom
wiktor/auto-patch-state-case-fix-next

Conversation

@WiktorStarczewski
Copy link
Copy Markdown
Collaborator

Cherry-pick of the main hotfix; same content. See #67 for details.

gh's REST API returns pull-request state as 'open' / 'closed', GraphQL
returns 'OPEN' / 'CLOSED'. The closed-PR guardrail in the composite
action and the dev script were comparing against the uppercase form,
so the closed-without-merge branch always fired even on open PRs —
the action exited with 'is closed without merge' on every run with a
'Client PR:' marker.

Normalize the API-returned value via tr to lowercase, then compare to
'open'. Verified against miden-client#2059 (state='open' from REST).
@WiktorStarczewski WiktorStarczewski added the no changelog PR doesn't need a CHANGELOG entry (trivial / non-user-visible) label Apr 30, 2026
@WiktorStarczewski WiktorStarczewski merged commit e2d3b1a into next Apr 30, 2026
32 of 33 checks passed
@WiktorStarczewski WiktorStarczewski deleted the wiktor/auto-patch-state-case-fix-next branch April 30, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR doesn't need a CHANGELOG entry (trivial / non-user-visible)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant