Skip to content

ci: wire inject-linked-client-pr into clippy-wasm + publint+attw#71

Merged
WiktorStarczewski merged 1 commit into
mainfrom
wiktor/auto-patch-clippy-publish-coverage
Apr 30, 2026
Merged

ci: wire inject-linked-client-pr into clippy-wasm + publint+attw#71
WiktorStarczewski merged 1 commit into
mainfrom
wiktor/auto-patch-clippy-publish-coverage

Conversation

@WiktorStarczewski
Copy link
Copy Markdown
Collaborator

Coverage gap from #65: only build.yml/build-wasm and test.yml's two cargo-using jobs were wired up. Clippy WASM and publint+attw also compile cargo on the workspace dep. Without the patch, they hit canonical crates.io 0.14.5 and fail with missing-variant errors when a PR depends on an unreleased upstream API. Add the action call (with default comment=false) so build-wasm remains the single sticky-comment poster.

PR #25's verification run surfaced a coverage gap: my initial wiring
in #65 only patched build.yml's build-wasm and test.yml's
build-web-client-dist-folder + verify-release-build. But Clippy WASM
(in lint.yml) and publint + attw (in check-publish.yml) ALSO compile
cargo against the workspace's miden-client dep — without the patch,
they hit canonical crates.io `miden-client = "0.14.5"` and fail
with `error[E0599]: no variant named `ApplyTransactionAfterSubmitFailed``
when the PR depends on an unreleased upstream variant.

Add the action call after checkout in both jobs. Both run with
comment=false (the default); build-wasm remains the single sticky-
comment poster.
@WiktorStarczewski WiktorStarczewski added the no changelog PR doesn't need a CHANGELOG entry (trivial / non-user-visible) label Apr 30, 2026
@WiktorStarczewski WiktorStarczewski merged commit 7fd9cfb into main Apr 30, 2026
20 of 21 checks passed
@WiktorStarczewski WiktorStarczewski deleted the wiktor/auto-patch-clippy-publish-coverage branch April 30, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR doesn't need a CHANGELOG entry (trivial / non-user-visible)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant