Skip to content

docs: add CONTRIBUTING.md documenting the 'Client PR: #N' marker workflow#77

Merged
WiktorStarczewski merged 1 commit into
mainfrom
wiktor/contributing-doc-client-pr
Apr 30, 2026
Merged

docs: add CONTRIBUTING.md documenting the 'Client PR: #N' marker workflow#77
WiktorStarczewski merged 1 commit into
mainfrom
wiktor/contributing-doc-client-pr

Conversation

@WiktorStarczewski
Copy link
Copy Markdown
Collaborator

Move README's Contributing section into a proper CONTRIBUTING.md and expand it with the cross-repo workflow that landed in #65/#66 (auto-patch + sticky comment + readiness gate). Also documents local-dev parity (scripts/dev-with-client-pr.sh) and the three situations where you still want to hand-edit Cargo.toml instead of using the marker.

README's Contributing section is now a one-line pointer.

…arker

The README's Contributing section was a stub. Move it into a proper
CONTRIBUTING.md (GitHub auto-detects this filename and surfaces it on
new-issue / new-PR pages) and expand it with the cross-repo workflow:

  - The 'Client PR: #N' marker convention (and the cross-repo /
    fork form 'Client PR: 0xMiden/miden-client#N')
  - What CI does with the marker (auto-patch action, sticky PR
    comment, readiness gate)
  - Branch-protection guidance (require linked-client-pr-ready, NOT
    the gate matrix job)
  - Local-dev parity (scripts/dev-with-client-pr.sh)
  - The three situations where you still want to hand-edit
    Cargo.toml instead of using the marker

README's Contributing section is now a one-line pointer.
@WiktorStarczewski WiktorStarczewski added the no changelog PR doesn't need a CHANGELOG entry (trivial / non-user-visible) label Apr 30, 2026
@WiktorStarczewski WiktorStarczewski merged commit 66f0916 into main Apr 30, 2026
20 of 21 checks passed
@WiktorStarczewski WiktorStarczewski deleted the wiktor/contributing-doc-client-pr branch April 30, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR doesn't need a CHANGELOG entry (trivial / non-user-visible)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant