fix(contracts): solve issue with foundry remappings#4
Open
0xGabi wants to merge 2 commits into0xPhaze:masterfrom
Open
fix(contracts): solve issue with foundry remappings#40xGabi wants to merge 2 commits into0xPhaze:masterfrom
0xGabi wants to merge 2 commits into0xPhaze:masterfrom
Conversation
Owner
|
Hi Gabi, thanks for your interest and for reporting this. Did you look into the discussion at Do you have |
Author
|
Oh I didn't know about that config for Here is the project were we are working with Note that I update the submodule to point to our forked version: https://github.com/BlossomLabs/OsmoticFund/blob/controller-tests/.gitmodules#L17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thank you for working on this. Super helpful when dealing with proxies and foundry!
Would like to propose this small update because since I upgrade to the latest nightly version of forge I started having this issue: foundry-rs/foundry#3440.