Merged
Conversation
cvauclair
requested changes
Jun 9, 2025
Contributor
cvauclair
left a comment
cvauclair
left a comment
There was a problem hiding this comment.
Nice work! Small thing to change but apart from that it looks good to merge
| } | ||
| } | ||
|
|
||
| impl<T: FromAttributes> Query<Vec<Relation>> for FindPathQuery<T> { |
Contributor
There was a problem hiding this comment.
In queries that return data, the generic type T is used to indicate what shape of data will be returned. However, since here were returning a "hardcoded" Vec<Relation> as the data, we don't actually need T.
There are two possible fixes:
- (recommended) Change the
impltoimpl Query<Vec<Relation>> for FindPathQuery<Vec<Relation>> - Remove
TfromFindPathQuery(not ideal since we might want to support more return types in the future)
cvauclair
requested changes
Jun 9, 2025
| skip: Option<usize>, | ||
| space_id: Option<PropFilter<String>>, | ||
| version: VersionFilter, | ||
| _phantom: std::marker::PhantomData<EntityNode>, |
Contributor
There was a problem hiding this comment.
Since FindPathQuery does not have a generic type parameter anymore, we don't need to have a _phantom field!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new tools for MCP server to query the knowledge graph
Modified: get_entity_info
Added: search_relation_between_2_entities
Added: get_entity_by_attribute
new function for resolving Id of entity to their name
embeddings are now available for the sample data