fix(checkpoint): count checkpoint signatures once per checkpoint#85
Merged
Conversation
Checkpoint signatures are republished on every poll cycle, but refreshCheckpoint only scanned the newest block window and returned early when it found no NewHeaderBlock event. Between checkpoints that left the stored entry at Seen=false, so the observer re-incremented missed_checkpoint_signature (and signed_checkpoint) every poll until the next checkpoint, inflating the counters by roughly the checkpoint-interval / poll-interval ratio. Track the last counted checkpoint via prevCheckpointID and, on the not-new path, mark the stored entry seen (as a fresh copy, since the previous pointer may still be in flight in an observer goroutine) so it is no longer counted on republish. The not-new path also skips the block/transaction lookups and signature recovery it no longer needs. Add provider/rpc_test.go covering the dedup state machine across poll cycles, including the once-per-checkpoint regression.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checkpoint signatures are republished on every poll cycle, but refreshCheckpoint only scanned the newest block window and returned early when it found no NewHeaderBlock event. Between checkpoints that left the stored entry at Seen=false, so the observer re-incremented missed_checkpoint_signature (and signed_checkpoint) every poll until the next checkpoint, inflating the counters by roughly the checkpoint-interval / poll-interval ratio.
Track the last counted checkpoint via prevCheckpointID and, on the not-new path, mark the stored entry seen (as a fresh copy, since the previous pointer may still be in flight in an observer goroutine) so it is no longer counted on republish. The not-new path also skips the block/transaction lookups and signature recovery it no longer needs.
Add provider/rpc_test.go covering the dedup state machine across poll cycles, including the once-per-checkpoint regression.
Jira / Linear Tickets
Testing