allow multiple source accounts for payment operations#2
Open
nikhilsaraf wants to merge 1 commit into0xfe:masterfrom
Open
allow multiple source accounts for payment operations#2nikhilsaraf wants to merge 1 commit into0xfe:masterfrom
nikhilsaraf wants to merge 1 commit into0xfe:masterfrom
Conversation
Owner
|
Thanks for the change, however it looks like it breaks some tests. Also, can you please add an additional test to cover this case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always add the SourceAccount to the
paymentMutsso we can submit a transaction that includes operations from different source accounts (this is different from the multisig use-case outlined in the readme).Sample Usage:
Always including the source account in the
paymentMutsis safe even if the source account matches the transaction's source account. This should ideally be done for all operations in microstellar, but it would be great if you could include this PR for now.