fix(podspec): set CocoaPods README URL#37
Merged
Conversation
|
Claude finished @tolgahan-arikan's task —— View job Reviewing PR: CocoaPods README URL FixI've completed my review of this pull request against the OMS SDK conventions in AGENTS.md. Here are my findings: Todo List:
✅ Review FindingsThis PR looks excellent and follows all the OMS SDK conventions perfectly: Security Analysis
Correctness Against AGENTS.md Conventions
Code Quality
Implementation DetailsThe change adds: s.readme = "https://raw.githubusercontent.com/0xsequence/swift-sdk/#{s.version}/README.md"This is exactly what's needed to:
Test Coverage Assessment
Publishing Workflow IntegrationThe SummaryThis PR is ready for merge. It's a minimal, well-tested change that solves the CocoaPods README rendering issue without introducing any risks to the SDK functionality, security, or conventions. |
andygruening
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an explicit versioned CocoaPods
s.readmeURL so the pod page can render the README for the published release instead of falling back to stale CocoaDocs README metadata. Updates the publishing checklist to preserve that metadata for future releases.Changes
s.readmeinoms-client-swift-sdk.podspecto the tag-specific raw GitHub README URL.publishing.md.Testing
git diff --checkpod ipc spec oms-client-swift-sdk.podspecpod ipc specresolvesreadmetohttps://raw.githubusercontent.com/0xsequence/swift-sdk/0.1.0-alpha.2/README.mdcurl -fsI https://raw.githubusercontent.com/0xsequence/swift-sdk/0.1.0-alpha.2/README.mdreturned HTTP 200swift buildpasses - not run; podspec/docs metadata onlyswift testpasses - not run; podspec/docs metadata onlyRelated
Follow-up to CocoaPods.org rendering stale README content for
oms-client-swift-sdk.