Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @dawguk,
Thanks for your great library, it helped me a lot to build some useful analytics.
This PR allows to pass additional filters to the
getActivityList() method because I needed to search for specific distances, between dates, sort by a column, [...], it's possible on Garmin Connect:Rather than adding X new parameters to your method, I just decided to add an optional array and merging it with the existing params:
Full example:
Note that
getActivityList($filters = array())would have been enough (because we can definestart,limit&activityTypein the same array) but to preserve backward compatibility, I decided to let the legacy params even if we can override them in that array.