fix: add null check for webviewRef in focus/blur event listeners#340
Open
sonubintw wants to merge 1 commit into
Open
fix: add null check for webviewRef in focus/blur event listeners#340sonubintw wants to merge 1 commit into
sonubintw wants to merge 1 commit into
Conversation
Fixes issue where addEventListener was called on undefined webviewRef, causing isFocused state to not sync properly when editor gains/loses focus.
There was a problem hiding this comment.
Pull request overview
Updates the native-side editor bridge to keep the isFocused state in sync when blur() is invoked.
Changes:
- Update
BridgeState.isFocusedtofalseinblur()via_updateEditorStatewheneditorStateRef.currentis available.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where addEventListener was called on undefined webviewRef, causing isFocused state to not sync properly when editor gains/loses focus.