fix: shouldSkipRedirect incorrectly skips cross-domain redirects#942
Open
fix: shouldSkipRedirect incorrectly skips cross-domain redirects#942
Conversation
Add host comparison check in shouldSkipRedirect to ensure cross-domain redirects are never skipped, even when pathnames match. This fixes an issue where redirects configured from one domain to another with the same pathname would result in 404 errors instead of proper redirects. Fixes #941 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 1e62299 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shouldSkipRedirectto ensure cross-domain redirects are never skippedFixes #941
Changes
packages/core/src/utils/fetchRedirect.ts:shouldSkipRedirectwhenlinkURL.host !== redirectURL.hostTest plan
🤖 Generated with Claude Code
Note
Low Risk
Low risk: small redirect-skip logic tweak plus targeted tests; main behavioral change is that cross-domain redirects will now be followed even when path/query match.
Overview
Fixes
fetchRedirectincorrectly treating cross-domain redirects as “no-op” when the pathname/query match by updatingshouldSkipRedirectto never skip redirects whenhostdiffers.Adds MSW handlers and unit tests covering cross-domain redirects for both same-path and different-path cases, and includes a patch changeset for
@headstartwp/core.Written by Cursor Bugbot for commit 1e62299. This will update automatically on new commits. Configure here.