fix: undefined array key 'context' warning in Gutenberg.php (PHP 8+)#943
Open
fix: undefined array key 'context' warning in Gutenberg.php (PHP 8+)#943
Conversation
Add null coalescing operator to check for context parameter existence before accessing it in extend_post_content method. This prevents PHP 8+ "Undefined array key" warnings that corrupt JSON responses when the context query parameter is not explicitly provided in REST API requests. Fixes #940 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 9338be8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contextparameter inextend_post_contentmethodFixes #940
Problem
The
extend_post_contentmethod inGutenberg.phpaccesses$params['context']without checking if the key exists. In PHP 8.0+, this triggers an "Undefined array key" warning when thecontextquery parameter is not explicitly provided in the REST API request.This warning is output before the JSON response, corrupting the response body:
Solution
Use the null coalescing operator to default to an empty string when
contextkey doesn't exist:Test plan
GET /wp-json/wp/v2/pages?slug=testGET /wp-json/wp/v2/pages?slug=test&context=view🤖 Generated with Claude Code
Note
Low Risk
Low risk: a small guard change that only affects the conditional gating of
extend_post_contentwhen the REST request omitscontext, preventing PHP 8+ warnings without changing behavior forcontext=viewrequests.Overview
Prevents PHP 8+ "Undefined array key" warnings in
Gutenberg::extend_post_contentby safely handling missing REST requestcontext(defaults to empty string) before deciding whether to extend the rendered content.Adds a patch changeset entry for the
@headstartwp/headstartwprelease.Written by Cursor Bugbot for commit 9338be8. This will update automatically on new commits. Configure here.