Add output url to image diff renderer#29
Merged
frankdekker merged 6 commits intomasterfrom Jul 29, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds optional URL configuration for the image diff renderer to improve user experience when running tests in CI environments. Instead of showing a local file path, users can now configure a web-accessible URL where the diff HTML file can be viewed.
- Introduces
PHPUNIT_EXTENSIONS_IMAGE_DIFF_OUTPUT_URLenvironment variable support - Modifies the constructor to accept and process an optional output URL parameter
- Updates the render method to use the configured URL when available instead of the local path
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Renderer/ImageDiffRenderer.php | Adds outputUrl property and constructor parameter, implements URL-based diff viewing |
| tests/Unit/Renderer/ImageDiffRendererTest.php | Adds test case to verify URL-based rendering functionality |
| README.md | Documents the new PHPUNIT_EXTENSIONS_IMAGE_DIFF_OUTPUT_URL environment variable |
Comments suppressed due to low confidence (1)
tests/Unit/Renderer/ImageDiffRendererTest.php:63
- The test method name 'testRenderShouldWithOutputUrl' is grammatically incorrect. Consider renaming it to 'testRenderShouldUseOutputUrl' or 'testRenderWithOutputUrl' for clarity.
public function testRenderShouldWithOutputUrl(): void
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bram123
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PHPUNIT_EXTENSIONS_IMAGE_DIFF_OUTPUT_URLto theImageDiffRendererto optionally set a url where the rendered diff will be available.