Skip to content

t128_tank: stream from the beginning if parsing the index fails #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregschrock merged 1 commit into from
Sep 17, 2025
Merged

t128_tank: stream from the beginning if parsing the index fails #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions plugins/inputs/t128_tank/reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,7 @@ func (r *Reader) Run(mainCtx context.Context) {
var observedValue uint64
lastIndex, err := r.getIndex(r.indexPath, r.defaultIndex)
if err != nil {
r.log.Errorf("Error in get index %v", err)
readCtxCancel()
return
r.log.Infof("Failed to get index %v", err)
}
nextSaveCheck := time.NewTicker(2 * time.Second)
defer func() {
Expand Down
28 changes: 25 additions & 3 deletions plugins/inputs/t128_tank/t128_tank_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ func TestT128TankReader(t *testing.T) {
Name string
IndexFile string
IndexFileContent string
IndexFileEmpty bool
Topic string
PortNumber int
ServerAddress string
Expand All @@ -38,7 +39,7 @@ func TestT128TankReader(t *testing.T) {
ExpectedMetrics []IndexedMessage
}{
{
Name: "index file with no value",
Name: "index file does not exist",
Topic: "events",
PortNumber: 11011,
ServerAddress: "127.0.0.2",
Expand All @@ -54,6 +55,24 @@ func TestT128TankReader(t *testing.T) {
},
},
},
{
Name: "index file empty",
Topic: "events",
IndexFileEmpty: true,
PortNumber: 11011,
ServerAddress: "127.0.0.2",
DefaultIndex: StartIndex,
TankReadCommandContext: func(ctx context.Context, name string, arg ...string) *exec.Cmd {
cmd := exec.CommandContext(ctx, "echo", "seq=1:measurement,core=2,node=test-1,port=corp-dmz-p value=0i 1586886775")
return cmd
},
ExpectedMetrics: []IndexedMessage{
{
Message: []byte("measurement,core=2,node=test-1,port=corp-dmz-p value=0i 1586886775"),
Index: index{value: 1},
},
},
},
{
Name: "index file with value",
IndexFileContent: "150",
Expand Down Expand Up @@ -87,7 +106,7 @@ func TestT128TankReader(t *testing.T) {
var wg sync.WaitGroup
indexFileName := strings.ReplaceAll(testcase.Name, " ", "_")
plugin.IndexFile = path.Join(t.TempDir(), fmt.Sprintf("%s.index", indexFileName))
if testcase.IndexFileContent != "" {
if testcase.IndexFileContent != "" || testcase.IndexFileEmpty {
err := os.WriteFile(plugin.IndexFile, []byte(testcase.IndexFileContent), 0755)
assert.NoError(t, err)
}
Expand Down Expand Up @@ -116,9 +135,12 @@ func TestT128TankReader(t *testing.T) {

cancel()

if len(testcase.ExpectedMetrics) > 0 {
assert.NotNil(t, receivedMessages)
}

if len(testcase.ExpectedMetrics) > 0 && receivedMessages != nil {
assert.Equal(t, testcase.ExpectedMetrics, receivedMessages)

}
})
}
Expand Down