WIP: Soft Delete all Domains - implemented on Person for API#60
WIP: Soft Delete all Domains - implemented on Person for API#60eeolivas wants to merge 10 commits into1701-jan09-java:masterfrom
Conversation
Merge pull request 1701-jan09-java#59 from eeolivas/master
need to update with base master in order to ceate PR
| return false; | ||
| } else if (!id.equals(other.id)) | ||
| return false; | ||
| if (isActive != other.isActive) |
There was a problem hiding this comment.
Replace this if-then-else statement by a single return statement. 
| @@ -58,7 +61,7 @@ public class Eval implements Serializable{ | |||
| public Eval() {/*empty constructor needed*/} | |||
|
|
|||
| public Eval(Integer week, Date date, EvalType evalType, Person trainee, Batch batch, | |||
There was a problem hiding this comment.
Constructor has 8 parameters, which is greater than 7 authorized.
| return false; | ||
| } else if (!id.equals(other.id)) | ||
| return false; | ||
| if (isActive != other.isActive) |
There was a problem hiding this comment.
Replace this if-then-else statement by a single return statement.
| @@ -16,11 +16,15 @@ public class Subject implements Serializable { | |||
| @Column(name = "s_subject") | |||
| private String subject; | |||
| return false; | ||
| } | ||
| if (!Objects.equals(this.id, other.id)) { | ||
| if (isActive != other.isActive) |
There was a problem hiding this comment.
Replace this if-then-else statement by a single return statement.
|
there are issues with admin delete Person. did not mean to push upstream yet |
tjkemper
changed the title
|
SonarQube analysis reported 8 issues
Watch the comments in this conversation to review them. 3 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
2 participants
dont merge this yet just want to make sure this is what we want - and figure a way to incorporate higher-level requests for hard deletes