Get sim, sim replay, deploy and deploy replay to work.#17
Open
MikeStitt wants to merge 1 commit into
Open
Conversation
…y replay to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggest that we develop some tests to go along with this change.
This pull request has the changes I made to PyKit to get this robotpy program: https://github.com/spiresfrc9106/spiresRobot2026/tree/41762640c5f6642aa6aab3dc169e8a447ac63d61
so that it would do
robotpy testof an auto drive out sim and and replay: See https://github.com/spiresfrc9106/spiresRobot2026/blob/41762640c5f6642aa6aab3dc169e8a447ac63d61/tests/replay_test.py#L82Note that changes to pyfrc to get the test to work are here: https://github.com/spiresfrc9106/spiresRobot2026/blob/41762640c5f6642aa6aab3dc169e8a447ac63d61/examples/pyfrc/pyfrc/test_support/pytest_isolated_tests_plugin.py#L248
This repo is currently running a local version of pykit here: https://github.com/spiresfrc9106/spiresRobot2026/tree/41762640c5f6642aa6aab3dc169e8a447ac63d61/pykit
The repo is able to do simulated replays of deployed robot pykit log files that play back the same.
I've been using this tool to compare realoutputs and replayoutputs portions of a replayed _sim.wpilog file.: https://github.com/spiresfrc9106/spiresRobot2026/blob/41762640c5f6642aa6aab3dc169e8a447ac63d61/tools/find_replay_divergence.py
Again, perhaps we should add some tests similar to
robotpy testof pykit similar to the one in tests/replay_test.py-Mike