fix: context menu z-order on canvas terminals#19
Merged
Conversation
Context menus were rendered behind overlapping terminal panels because the shared paint layer used Order::Tooltip, which has higher priority than Order::Foreground where context menus are drawn. Lowering the shared layer to Order::Foreground ensures context menus render on top, since egui draws non-Area paint layers before Area layers (like popups) within the same Order.
- Keep terminal shared layer at Order::Tooltip for proper z-ordering - Render context menu at Order::Debug (above Tooltip) using custom popup - Store click position in canvas space so menu moves with pan/zoom - Close menu on click-elsewhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Order::Tooltip, which has higher priority thanOrder::Foregroundwhere egui draws context menu popupsOrder::TooltiptoOrder::Foreground— within the same Order, egui draws non-Area paint layers before Area layers (like context menu popups), so menus now render on top of panel fillsTest plan