fix: selection follows scroll and auto-scrolls at viewport edges#20
Merged
fix: selection follows scroll and auto-scrolls at viewport edges#20
Conversation
When scrolling via mouse wheel during an active selection drag, the selection coordinates now stay in sync with the changing display offset. When dragging above or below the terminal viewport, the terminal auto-scrolls and extends the selection into newly visible content.
…tions Selection rows were usize, clamped to 0 when scrolling down past the start. Changed to i32 so the start can go negative (above viewport). The renderer already handles offset_delta correctly — removed the redundant scroll sync that was fighting with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auto_scroll_selection()to atomically scroll the terminal and update selection coordinates, preventing any mismatch between scroll state and selection state.Test plan