fix: sidebar interaction blocked by canvas area#21
Merged
Conversation
The canvas_content Area was positioned at Pos2::ZERO (screen origin), causing it to cover the entire screen including the sidebar region. Since this Area renders at Order::Middle (above the sidebar panel), it intercepted pointer events meant for sidebar items when terminal panels overlapped the sidebar area. Moving the Area origin to canvas_rect.min restricts it to the canvas region only, allowing sidebar right-clicks and other interactions to work correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
canvas_contentArea inapp.rswas positioned atPos2::ZERO(screen coordinate origin), causing it to span the entire screen including the sidebar regionOrder::Middle(above the sidebar panel at the base layer), it intercepted pointer events — such as right-clicks — meant for sidebar items whenever terminal panels on the canvas overlapped the sidebar areafixed_pos(Pos2::ZERO)tofixed_pos(canvas_rect.min)so the Area only covers the canvas region, allowing all sidebar interactions to work correctlyTest plan
🤖 Generated with Claude Code