fix masked profile secret preservation#13
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes credential handling in the configure HTTP API + dashboard so that masked secrets ("********") are not accidentally persisted back into credentials.json during profile updates, and ensures additional deploy backends have their tokens masked by default.
Changes:
- Added masking for Cloudflare and EdgeOne deploy profile API tokens in the serve layer.
- Added server-side logic to preserve existing secrets when an upsert payload contains the masked sentinel.
- Updated the dashboard secret inputs to display masked secrets as empty with an “unchanged” placeholder, plus i18n copy updates and new tests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cli/internal/serve/mask.go | Adds masking for Cloudflare/EdgeOne tokens and applies it in maskConfig. |
| packages/cli/internal/serve/handlers_configure.go | Preserves existing secrets on upsert when the payload contains the mask sentinel. |
| packages/cli/internal/serve/handlers_configure_test.go | Adds regression tests for masked-secret preservation and deploy token masking. |
| apps/dashboard/src/pages/SectionDetail.tsx | Renders masked secrets as empty inputs with an “unchanged” placeholder to avoid resubmitting "********". |
| apps/dashboard/src/locales/zh-CN.json | Updates edit description and adds secret-unchanged placeholder string. |
| apps/dashboard/src/locales/en-US.json | Updates edit description and adds secret-unchanged placeholder string. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.