Bump the npm_and_yarn group across 1 directory with 5 updates - #1
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Bumps the npm_and_yarn group with 5 updates in the /airflow-core/src/airflow/ui directory: | Package | From | To | | --- | --- | --- | | [@modelcontextprotocol/sdk](https://github.com/modelcontextprotocol/typescript-sdk) | `1.11.0` | `1.24.2` | | [body-parser](https://github.com/expressjs/body-parser) | `2.2.0` | `2.2.1` | | [brace-expansion](https://github.com/juliangruber/brace-expansion) | `1.1.11` | `1.1.12` | | [js-yaml](https://github.com/nodeca/js-yaml) | `3.14.1` | `3.14.2` | | [mdast-util-to-hast](https://github.com/syntax-tree/mdast-util-to-hast) | `13.2.0` | `13.2.1` | Updates `@modelcontextprotocol/sdk` from 1.11.0 to 1.24.2 - [Release notes](https://github.com/modelcontextprotocol/typescript-sdk/releases) - [Commits](modelcontextprotocol/typescript-sdk@1.11.0...1.24.2) Updates `body-parser` from 2.2.0 to 2.2.1 - [Release notes](https://github.com/expressjs/body-parser/releases) - [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md) - [Commits](expressjs/body-parser@v2.2.0...v2.2.1) Updates `brace-expansion` from 1.1.11 to 1.1.12 - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.12) Updates `js-yaml` from 3.14.1 to 3.14.2 - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.1...3.14.2) Updates `mdast-util-to-hast` from 13.2.0 to 13.2.1 - [Release notes](https://github.com/syntax-tree/mdast-util-to-hast/releases) - [Commits](syntax-tree/mdast-util-to-hast@13.2.0...13.2.1) --- updated-dependencies: - dependency-name: "@modelcontextprotocol/sdk" dependency-version: 1.24.2 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: body-parser dependency-version: 2.2.1 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: brace-expansion dependency-version: 1.1.12 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: mdast-util-to-hast dependency-version: 13.2.1 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Author
|
Superseded by #2. |
dependabot
Bot
deleted the
dependabot/npm_and_yarn/airflow-core/src/airflow/ui/npm_and_yarn-58d89e05a4
branch
February 19, 2026 14:38
1fanwang
pushed a commit
that referenced
this pull request
Jun 5, 2026
* Fixing pod leak in KubernetesJobOperator (#1) * fix(providers/cncf/kubernetes): clean up monitoring pods in KubernetesJobOperator KubernetesJobOperator inherited from KubernetesPodOperator but overrode execute() without calling post_complete_action(), so the monitoring / log-streaming pods discovered via get_pods() were never deleted. These pods have no ownerReferences to the V1Job, so ttl_seconds_after_finished and the Foreground cascade in on_kill don't reap them either. - execute() and execute_complete() now wrap their work in try/finally and call post_complete_action() for each pod in self.pods. on_finish_action (delete_pod / delete_succeeded_pod / keep_pod) is now honoured. - on_kill() additionally calls pod_manager.delete_pod() for each monitoring pod (the Job's foreground cascade doesn't reach them). - Per-pod cleanup errors are logged but never mask the in-flight exception, so Job-level failures keep propagating. - execute_complete() resolves monitoring pods once and shares the lookup between the log-retrieval path and the cleanup path. - Added unit tests, a bugfix newsfragment, and an operators.rst section documenting the cleanup contract. * Address code review feedback: remove dead PodNotFoundException check, drop unused import, relax pod-deletion ordering in test, fix trailing comma * Potential fix for pull request finding In _cleanup_monitoring_pods, remote_pod is resolved via find_pod(), which is designed to locate a single matching pod by task-instance labels and can invoke duplicate-pod resolution logic (process_duplicate_label_pods). For KubernetesJobOperator with parallelism > 1, this lookup can return the wrong pod (or trigger duplicate-handling side effects), so post_complete_action() may receive a mismatched remote_pod. Consider using the already-discovered pod’s name/namespace to refresh state (e.g. via hook.get_pod) or just pass remote_pod=pod when you already have the V1Pod object from get_pods(). Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Use isinstance(exc, TaskDeferred) instead of brittle string comparison * Potential fix for pull request finding The new unit tests add several mock.MagicMock() instances (pods, jobs, TI, etc.) without spec/autospec, and some patch() usages also create non-spec'd mocks by default. Using autospec=True on patches and create_autospec(...)/MagicMock(spec=...) for key Kubernetes objects helps catch typos/attribute mismatches in these tests and aligns with Airflow’s test hardening guidance. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Address PR review comments: fix trigger pod_names, on_kill logging, and test assertions - triggers/job.py: Always include pod_names/pod_namespace in trigger event regardless of get_logs setting, so execute_complete() can reliably clean up monitoring pods even when get_logs=False - operators/job.py: Log unexpected ApiException in on_kill() instead of suppressing all ApiExceptions; remove unused `suppress` import - tests/test_job.py: Rewrite test_execute_respects_keep_pod and test_execute_deletes_pod_default to keep process_pod_deletion real and assert on pod_manager.delete_pod; stub hook.get_pod for remote_pod resolution - tests/test_job.py: Add regression test for get_logs=False deferrable path * Fix orphaned test_on_kill_deletes_monitoring_pods method body after accidental deletion of method signature * Make pod resolution best-effort in execute_complete * Address remaining KubernetesJobOperator review comments * Finalize review-comment fixes for KubernetesJobOperator * Fix remaining KubernetesJobOperator review comments * Update KubernetesJobOperator docs for action semantics * Improve KubernetesJobOperator newsfragment readability --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Ville Jyrkkä <vjyrkka@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Apply ruff format * Move provider changelog entry; drop newsfragment * Apply prek docstring auto-fix (D212 multi-line summary) * Drop changelog entry — added by release manager at release time * Cover remaining KubernetesJobOperator monitoring-pod cleanup paths * Consolidate PR tests: drop call-counting, dedupe, observe state * Apply test review fixes: hoist imports, add state assertions, dedupe with _pod helper * Fix Copilot review: spec all MagicMock usages in KubernetesJobOperator tests - _recording_pod_manager(): use create_autospec(PodManager) instead of MagicMock - test error masking: use create_autospec(PodManager) for boom-raising pm - test_execute_does_not_cleanup_when_deferring: use create_autospec(KubernetesJobTrigger) for trigger - test_execute_complete_pod_api_error_does_not_raise: use plain {} for event["job"] field - test_run_success_emits_pod_info_when_get_logs_false (triggers): use create_autospec(k8s.V1Job) --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the npm_and_yarn group with 5 updates in the /airflow-core/src/airflow/ui directory:
1.11.01.24.22.2.02.2.11.1.111.1.123.14.13.14.213.2.013.2.1Updates
@modelcontextprotocol/sdkfrom 1.11.0 to 1.24.2Release notes
Sourced from
@modelcontextprotocol/sdk's releases.... (truncated)
Commits
d23674dchore: bump version to 1.24.2 (#1224)7c9257crefactor: make Server class framework-agnostic by moving express to separate ...401a189chore: refresh CLAUDE.md (#1217)4b5c25dfeat: add optional resource annotations (#954)6dd7cd4chore: bump version for release (#1219)600859fchore: update protocol version to 2025-11-25 (#1218)bfad917fix(streamableHttp): fix infinite retries when maxRetries is set to 0 (#1216)356b7e6chore: bump version for release (#1215)09623e2Merge commit from forkcf51343feat: backwards-compatible createMessage overloads for SEP-1577 (#1212)Maintainer changes
This version was pushed to npm by pcarleton, a new releaser for
@modelcontextprotocol/sdksince your current version.Updates
body-parserfrom 2.2.0 to 2.2.1Release notes
Sourced from body-parser's releases.
... (truncated)
Changelog
Sourced from body-parser's changelog.
Commits
d96b63d2.2.1 (#659)b204886sec: security patch for CVE-2025-13466e20e351feat: removehistory.mdfrom being packaged on publish (#660)0d7ce71docs: switch badges from badgen.net to shields.io (#661)168afffci: also test on first supported node.js version (#646)e539a71build(deps): bump actions/setup-node from 5.0.0 to 6.0.0 (#654)9391612build(deps): bump actions/upload-artifact from 4.6.2 to 5.0.0 (#655)57baafbbuild(deps): bump github/codeql-action from 3.30.5 to 4.31.2 (#656)a6a088ebuild(deps): bump actions/download-artifact from 5.0.0 to 6.0.0 (#657)10a114dtest: add test for urlencoded invalid defaultCharset (#643)Updates
brace-expansionfrom 1.1.11 to 1.1.12Release notes
Sourced from brace-expansion's releases.
Commits
44f33b41.1.12c460dbdpkg: publish on tag 1.xccb8ac6fmtc3c73c8Fix potential ReDoS Vulnerability or Inefficient Regular Expression (#65)Updates
js-yamlfrom 3.14.1 to 3.14.2Changelog
Sourced from js-yaml's changelog.
... (truncated)
Commits
9963d363.14.2 released10d3c8edist rebuild5278870fix prototype pollution in merge (<<) (#731)Updates
mdast-util-to-hastfrom 13.2.0 to 13.2.1Release notes
Sourced from mdast-util-to-hast's releases.
Commits
174795b13.2.13d05b3aUpdate Node in Actionsab3a795Fix support for spaces in class namesefb5312Refactor to use@importsa5bc210Add declaration mapsb54955dAdd.tsbuildinfoto.gitignoreDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.