AIP-97: document the infra-refund config and failure_kind listener use - #18
Draft
1fanwang wants to merge 1 commit into
Draft
AIP-97: document the infra-refund config and failure_kind listener use#181fanwang wants to merge 1 commit into
1fanwang wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1fanwang
force-pushed
the
aip97-p3-infra-refund
branch
from
July 27, 2026 18:11
7d568c9 to
7214d65
Compare
Adds the two [core] options the refund path introduces (infra_failure_refund_retries and max_infra_refunds) to config.yml so they appear in the config reference, and extends the listener failure-cause example to route on failure_kind: record an infrastructure disruption as capacity churn for metrics and dashboards, page on-call for a real failure. Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
force-pushed
the
aip97-p3-infra-refund
branch
from
July 27, 2026 20:01
7214d65 to
c822f45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author-facing docs for AIP-97, stacked on the refund PR (#13).
What
[core]options added by the refund path:infra_failure_refund_retries(opt-in) andmax_infra_refunds(the cap). They now appear in the generated config reference instead of living only as code fallbacks.failure_kind: record an infrastructure disruption as capacity churn for metrics and dashboards, and page on-call for a real failure. Teams that already build Dag and task lifecycle tracking on these listeners get a field that separates infrastructure churn from application bugs.Testing
confreads the new defaults at runtime:max_infra_refundsis3, andinfra_failure_refund_retriesisFalse.config.ymlparses, and both entries are well formed. The listener change is a docs example.