[doc] fix jsonrepair upstream link; clarify capability bits (LET-29)#168
Conversation
…ffects - lib/json/README pointed `repair`'s vendored jsonrepair at RealAlexandreAI/json-repair, but the actual vendored upstream is kaptinlin/jsonrepair v0.2.2 (per internal/jsonrepair/doc.go, its LICENSE "Copyright (c) 2024 KaptinLin", codecov.yml and .codacy.yml). Correct the link. - ModuleCapability doc: clarify the bits model host *effects* (fs/net/process/log) only, not determinism/reproducibility. random is CapPure (no side effects) yet non-deterministic by design; a "replayable/pure-function" set belongs on the consumer side (excluding entropy/clock sources), not these bits. Requirement: LET-29. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
🟢 Coverage ∅ diff coverage · +0.01% coverage variation
Metric Results Coverage variation ✅ +0.01% coverage variation (-1.00%) Diff coverage ✅ ∅ diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (433eae0) 7692 7276 94.59% Head commit (7f60e37) 7692 (+0) 7277 (+1) 94.60% (+0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#168) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #168 +/- ##
==========================================
+ Coverage 93.39% 93.41% +0.01%
==========================================
Files 49 49
Lines 6177 6177
==========================================
+ Hits 5769 5770 +1
+ Misses 260 258 -2
- Partials 148 149 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What
Two documentation corrections:
jsonrepair upstream link.
lib/json/README.mdpointedrepair's vendored jsonrepair atRealAlexandreAI/json-repair, but the actual vendored upstream iskaptinlin/jsonrepairv0.2.2 — confirmed byinternal/jsonrepair/doc.go, itsLICENSE(Copyright (c) 2024 KaptinLin),codecov.yml, and.codacy.yml. Fix the link to match.Capability bits clarification. The
ModuleCapabilitydoc now states the bits model host effects (filesystem/network/process/log) only, not determinism/reproducibility.randomisCapPure(no host side effects) yet non-deterministic by design; a consumer needing a "replayable / pure-function" set should define it on its own side (excluding entropy/clock sources such asrandomandtime) rather than reading it off these bits.Doc-only; no behavior change.
Requirement: LET-29