Add ability to set preview image via AssetFields#132
Open
keichinger wants to merge 8 commits into3.xfrom
Open
Conversation
keichinger
commented
Jun 4, 2024
keichinger
force-pushed
the
preview-image-field
branch
from
3e7e6a3 to
bd87f15
Compare
apfelbox
reviewed
Jun 5, 2024
apfelbox
reviewed
Jun 5, 2024
apfelbox
previously approved these changes
Jun 5, 2024
keichinger
force-pushed
the
preview-image-field
branch
from
bd87f15 to
d43538b
Compare
…on-text-based fields
keichinger
force-pushed
the
preview-image-field
branch
from
d43538b to
f3e6bf3
Compare
apfelbox
reviewed
Jul 31, 2025
|
|
||
| if (null !== $previewField && null !== $previewImageField) | ||
| { | ||
| break; |
Member
There was a problem hiding this comment.
It now can't happen that we have two different preview field vs asset preview, right? Is that something that can happen in theory? Or can it only ever be one?
apfelbox
reviewed
Jul 31, 2025
| { | ||
| if ($this->allowMultiselect) | ||
| { | ||
| throw new InvalidFieldConfigurationException("The choice field with multiselect can't be used as preview field."); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.