feat: mobile note move actions via context menu#208
Merged
Conversation
Add Move Up, Move Down, Indent (move into sibling above), and Outdent (move out of parent) to the long-press context menu on mobile/tablet. Replaces drag-and-drop which isn't available on touch devices. Also fixes: Android build identifier (com.2pisoftware → com.twopisoftware), #[cfg(desktop)] gate on manage_scripts_menu_item, and android-dev.sh --device/--emulator flags.
Four buttons (Copy Note, Tree Actions, Invite, Share) used regular quotes instead of backticks, so itemClass wasn't interpolated — causing inconsistent padding and font sizes.
Add outline-none to suppress the browser's default black border on
the tabIndex={0} tree div. The focus-visible ring still shows on
keyboard navigation.
The tree div is just a keyboard event target — the selected node already highlights, so a container-level focus ring is redundant and visually distracting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.2pisoftware→com.twopisoftware),#[cfg(desktop)]gate onmanage_scripts_menu_item, andandroid-dev.sh--device/--emulatorflagsTest plan
npx tsc --noEmit)