Add a typedef to 32 bit unsigned int as "Color"

[optozorax]

Fixes #30

Example of what modern LLMs are capable of.

Harness: Codex
Model: GPT-5.4
Reasoning level: Extra High
Subscription: 20$
Weekly limit spent: 4%

First prompt:

I want to add a typedef to 32 bit unsigned int as "Color"

Ugly refactor that I'm too lazy to do now, but want to fix eventually across the whole codebase

expectation:
* everywhere that there is a color, we refer to it as Color in both cuda and cpp
* make the typedef in color.cpp
* Resolve any issues which I can't think of

Before performing a refactoring, can you find troubling places of this?

Answer:

• Trouble Spots

  - The alias cannot live in a .cpp. The current color primitives are header-only in src/Core/Color.h:6 and src/CUDA/
    color.cuh:6, and both still expose int-based color APIs. There also is no color.cpp in the tree. If Color needs to
    work in both C++ and CUDA, it has to be defined in a shared header.
  - Pixels is the biggest churn point. Its storage is vector<unsigned int> but most of its API is int-typed, including
    constants and drawing calls in src/Core/Pixels.h:13, src/Core/Pixels.h:33, src/Core/Pixels.h:39, and src/Core/
    Pixels.h:42. Changing that cleanly will ripple through most scene code and CUDA interop.
  - Pixels is not always storing actual ARGB colors. In convolution/segmentation it is used as a generic integer label
    buffer, writing component IDs into pixels in src/Core/Convolution.cpp:41, src/Core/Convolution.cpp:61, and comparing
    Math/GraphScene.h:16, src/Scenes/Math/RealFunctionScene.h:22, src/Scenes/Math/MandelbrotScene.cpp:7, src/Scenes/
    Math/GeodesicScene.cpp:12. So this is not a pure mechanical search/replace.
  - There are duplicate color helpers outside the main color headers. AlphaFilterScene.cpp has its own coldist, and
    mandelbrot.cu has its own cuda_color_lerp and palette handling instead of using the shared CUDA color helpers: src/
    Scenes/Media/AlphaFilterScene.h:8, src/CUDA/mandelbrot.cu:11.

  Questions

  - Are you okay with me putting typedef uint32_t Color; in a small shared header and including it from both the CPU and
    CUDA color headers? That is the only clean way to make this visible everywhere.
  - For Pixels, do you want the pragmatic version now: convert obvious color-facing APIs and fields to Color, but leave
    the segmentation/label-map misuse alone for now? That is what I’d recommend.
  - Do you want this pass to also normalize the duplicate color helpers like AlphaFilterScene and mandelbrot.cu, or keep
    the refactor strictly to the type alias?

  I haven’t changed any code yet.

Second prompt:

make your own choices about how to refactor that, what would be better, what is healthier and better in the long-term

Answer:

• I refactored the main color path around a real shared alias: /mnt/c/Users/optozorax/Desktop/portals/swaptube/src/
  Host_Device_Shared/Color.h. I did not put it in a .cpp, because that would not reach headers or CUDA; long-term the
  shared header is the only sane place for it. From there I converted the central color helpers in /mnt/c/Users/
  optozorax/Desktop/portals/swaptube/src/Core/Color.h and /mnt/c/Users/optozorax/Desktop/portals/swaptube/src/CUDA/
  color.cuh, the pixel container in /mnt/c/Users/optozorax/Desktop/portals/swaptube/src/Core/Pixels.h, shared 3D structs
  in /mnt/c/Users/optozorax/Desktop/portals/swaptube/src/Host_Device_Shared/ThreeDimensionStructs.h, and a broad set of
  scene/IO/CUDA entry points so actual colors are spelled as Color instead of raw int/unsigned int/uint32_t.

  I also swept the obvious color-bearing APIs and fields across C++ and CUDA, including graph/lambda types, scene color
  schemes, writer background color, and CUDA image buffers. The remaining raw int color hits are only in
  archived .oldproject files and *_needs_refactor code that was already marked out-of-band.

  Verification: I could not run the full project build here because this machine has no cmake, ninja, or nvcc. I did run
  g++ -std=c++17 -I. -fsyntax-only successfully on representative refactor-heavy C++ files including LambdaUtils.cpp,
  MandelbrotScene.cpp, ComplexPlotScene.cpp, AngularFractalScene.cpp, PendulumGridScene.cpp, StateSliderScene.cpp,
  RealFunctionScene.cpp, MandelbulbScene.cpp, ConwayScene.cpp, ManifoldScene.cpp, and the Beaver scene wrappers. Some
  other files could not be syntax-checked here because this environment is also missing FFmpeg dev headers and nlohmann/
  json.hpp.