* io.ReadAtLeast can read more bytes from the source than needed#1
Open
RangelReale wants to merge 1 commit into32bitkid:masterfrom
Open
* io.ReadAtLeast can read more bytes from the source than needed#1RangelReale wants to merge 1 commit into32bitkid:masterfrom
RangelReale wants to merge 1 commit into32bitkid:masterfrom
Conversation
…you read directly from the source after using bitreader, some bytes may have been "lost"
Owner
|
I'll have to think about this a little bit more. The The intended work-around was that My hesitation here is the specific usage of |
Author
|
This is the code that had trouble for me, I was reading an .swf file header, and there is a "Rect" structure that uses variable number of bits, but there is more data to be read after this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you read directly from the source after using bitreader, some bytes may have been "lost"