Support Laravel 13.x#28
Open
chrillep wants to merge 4 commits into
Open
Conversation
* Bump dependencies for Laravel 13 * PHPUnit 12 Shift (#2) * Bump PHPUnit dependencies * Set return type of base TestCase methods From the [PHPUnit 8 release notes][1], the `TestCase` methods below now declare a `void` return type: - `setUpBeforeClass()` - `setUp()` - `assertPreConditions()` - `assertPostConditions()` - `tearDown()` - `tearDownAfterClass()` - `onNotSuccessfulTest()` [1]: https://phpunit.de/announcements/phpunit-8.html * Adopt PHP attributes in test classes * Add return types to test methods * Define test classes as `final` --------- Co-authored-by: Shift <shift@laravelshift.com> --------- Co-authored-by: Shift <shift@laravelshift.com>
* Initial plan * Fix alphabetical ordering of use statements in test files Co-authored-by: chrillep <1267931+chrillep@users.noreply.github.com> Agent-Logs-Url: https://github.com/chrillep/etagconditionals/sessions/2a850694-3bc5-4413-ae12-ff9aac9bd13e --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: chrillep <1267931+chrillep@users.noreply.github.com>
* Initial plan * Fix PHP runtime build error: downgrade PHP version from 8.3 to 8.2 in .scrutinizer.yml Co-authored-by: chrillep <1267931+chrillep@users.noreply.github.com> Agent-Logs-Url: https://github.com/chrillep/etagconditionals/sessions/43f5e0f4-10a3-44ce-85be-9daaf2331fff * Fix Scrutinizer CI: pin PHP to 8.3.3 to avoid broken 8.3.4 mirror Co-authored-by: chrillep <1267931+chrillep@users.noreply.github.com> Agent-Logs-Url: https://github.com/chrillep/etagconditionals/sessions/9c5eff0d-2a61-4f8c-9f84-20f4a2a6292d * Fix Scrutinizer CI: update PHP version to 8.3.28 (confirmed working on mirror) Co-authored-by: chrillep <1267931+chrillep@users.noreply.github.com> Agent-Logs-Url: https://github.com/chrillep/etagconditionals/sessions/37d5f5ba-b4e9-49d9-9ff7-76ccff4dfdd6 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: chrillep <1267931+chrillep@users.noreply.github.com>
Author
|
@HergenD @asbiin if and or when you merge it could you please bump the version on packagist https://packagist.org/packages/werk365/etagconditionals aswell. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump dependencies for Laravel 13
PHPUnit 12 Shift (PHPUnit 12 Shift chrillep/etagconditionals#2)
Bump PHPUnit dependencies
Set return type of base TestCase methods
From the PHPUnit 8 release notes, the
TestCasemethods below now declare avoidreturn type:setUpBeforeClass()setUp()assertPreConditions()assertPostConditions()tearDown()tearDownAfterClass()onNotSuccessfulTest()Adopt PHP attributes in test classes
Add return types to test methods
Define test classes as
finalcloses #27