Skip to content

Add Boolean mesh materialization and a WASM binding temporary patch#466

Merged
vijaiaeroastro merged 2 commits into
developfrom
improve/boolean
Jul 23, 2026
Merged

Add Boolean mesh materialization and a WASM binding temporary patch#466
vijaiaeroastro merged 2 commits into
developfrom
improve/boolean

Conversation

@vijaiaeroastro

Copy link
Copy Markdown
Collaborator

Adds BooleanObject::MergeToMeshObject() to materialize an evaluated Boolean CSG shape as a normal mesh object in the same Model.

This lets clients retrieve and use the tessellated result directly, without exporting it through an STL writer first.

Changes

  • Add MergeToMeshObject() to the Boolean public API.
  • Generate bindings for all supported language targets.
  • Add C++ coverage for materializing and inspecting the resulting mesh.

Unrelated Included Fixes

  • Add the missing slice-stack vertex binding required by the 3MF Viewer.
  • Apply the current WASM generated-binding patch for struct-return handling.

@vijaiaeroastro
vijaiaeroastro requested review from 3dJan and gangatp July 22, 2026 04:34
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.56757% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.05%. Comparing base (82c524d) to head (659fbbe).

Files with missing lines Patch % Lines
Autogenerated/Source/lib3mf_interfacewrapper.cpp 65.51% 10 Missing ⚠️
Autogenerated/Bindings/Cpp/lib3mf_implicit.hpp 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #466      +/-   ##
===========================================
+ Coverage    60.04%   60.05%   +0.01%     
===========================================
  Files           67       67              
  Lines        25269    25306      +37     
===========================================
+ Hits         15173    15198      +25     
- Misses       10096    10108      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@3dJan 3dJan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.

@vijaiaeroastro
vijaiaeroastro merged commit a8e077d into develop Jul 23, 2026
44 checks passed
@vijaiaeroastro
vijaiaeroastro deleted the improve/boolean branch July 23, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants