You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello @gviga, I'm starting to review this PR and I already have a question about the two new classes.
The call methods are basically identical, and the init methods too. Would it not be enough to add a method in the base classes that returns the scale-invariant descriptors instead of creating new classes?
I understand the object-oriented approach, but in this case I'm not sure it is trurly useful.
Hi @GiLonga ,
Thank tou for reviewing this PR. I'm not sure i got your point:
Are you referring to the fact that both ScaleInvariantHKS and LandMark scale invariant hks have the same call function?
About the object-oriented approach: we need a scale-invariant-hks class with a call function that computes the descriptor, so it is compatible with the API of any descriptor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pr add a scale invariant version of the Heat Kernel Signature to the possible descriptors to use.