DIscrete Optimization, Smooth Functional Maps, Bijective ZoomOut#37
Draft
DIscrete Optimization, Smooth Functional Maps, Bijective ZoomOut#37
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 81.08% 82.16% +1.08%
==========================================
Files 45 45
Lines 1385 1632 +247
==========================================
+ Hits 1123 1341 +218
- Misses 262 291 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces three additional refinement methods from:
[1] MapTree: Recovering Multiple Solutions in the Space of Maps (https://arxiv.org/abs/2006.02532)
[2] Discrete Optimization for Shape Matching (https://www.lix.polytechnique.fr/~maks/papers/SGP21_DiscMapOpt.pdf)
[3] Smooth Non-Rigid Shape Matching via Effective Dirichlet Energy Optimization (https://arxiv.org/abs/2210.02870)
Some of these methods extend the conversion modules and refinement modules, needing to create a BijectiveItaretiveRefiner and other modifications of Converters.
[2] can be seen as a generalization of the ZoomOut algorithm. We could think to a redescign in which ZoomOut is a special instance of this algorithm. However, I think it would be cool to have also different implementations and then show that they are equivalent.
In general, we have to discuss whether the current structure of the converter (that takes a FM and return a p2p) can be extended to a common structure that can be used also when we want to input 2FM and return the two p2p in both directions, or it is better to create different converter classes for each purpose.