Handle ambiguous and nested encrypted QR codes, and hide legacy AES v1 modes#345
Handle ambiguous and nested encrypted QR codes, and hide legacy AES v1 modes#3453rdIteration merged 4 commits into3rdIteration:devfrom
Conversation
|
Notes
At present, all of these new features are meaningful only when used in combination with Krux’s Datum tool. |
Agent-Logs-Url: https://github.com/3rdIteration/seedsigner/sessions/7b9829ce-629d-4855-8cbb-1c809fcb3bae Co-authored-by: 3rdIteration <2230318+3rdIteration@users.noreply.github.com>
|
@codex can you include this document https://github.com/3rdIteration/seedsigner/blob/763cf91a38c2b3fdc56e65c917d5eb47deac1023/demo_qr_codes/README.md in a comment |
|
To use Codex here, create a Codex account and connect to github. |
|
QR codes to demonstrate this are here: https://github.com/3rdIteration/seedsigner/blob/763cf91a38c2b3fdc56e65c917d5eb47deac1023/demo_qr_codes/README.md |
|
(I'll review and merge tomorrow) |
|
@earthdiver Hey so I'm looking at this and given that it can result in different seeds, should probably just default to prompt if encrypted QR is enabled (which it is by default) as opposed to how it is currently where it defaults to treat as compact seed QR, |
|
Got it. I don’t have any particular preference. |
|
Thank you for merging this PR. By the way, in terms of differences from Krux behavior, the ShSi version differs not only in supporting static QR codes only, but also in supporting only Base43 for text-encoded encrypted data. Krux can automatically detect and decode encrypted data encoded as Base64, Base32, or hex as well, whereas the ShSi version supports only Base43. I do not think this is a major issue, but do you think it would be better to align it with Krux? (On the other hand, Krux cannot decode encrypted QR data when the encrypted payload contains nested Base43-encoded encrypted data, whereas the ShSi version can.) |
|
No worries, I the key thing is that it works for the default encrypted seed workflow, which it currently does. That said, supporting all the other stuff would be nice to have as well if you are feeling so inclined to code it :) |
|
Got it. I’ll implement it when I feel like it. |
Description
Added support for nested encrypted QR codes
(currently limited to static QR codes)
Added support for ambiguous QR codes. You can now choose in Settings how to handle QR codes that could be interpreted as either CompactSeedQR or EncryptedQR (or xprv).
Handle decrypted text from encrypted QR codes (as an alternative to PR Handle text payloads in encrypted QR decoding #175)
Hid legacy AES v1 modes from the encryption mode selector
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: