move backend usage cleanup from backend deleting fixture to service f…#913
Open
mkudlej wants to merge 3 commits into3scale-qe:mainfrom
Open
move backend usage cleanup from backend deleting fixture to service f…#913mkudlej wants to merge 3 commits into3scale-qe:mainfrom
mkudlej wants to merge 3 commits into3scale-qe:mainfrom
Conversation
mkudlej
requested review from
dhlavac and
mdujava
and removed request for
a team
Member
|
Is there a reason why those deletes are not after check for skip_clenup? |
Author
|
mdujava
reviewed
Jan 21, 2025
| except Exception: # pylint: disable=broad-except | ||
| pass | ||
|
|
||
| for usage in svc.backend_usages.list(): |
Member
There was a problem hiding this comment.
This is reached after backend_usages are deleted, unless order of fixtures is changed in a tests to have backend_usages before service.
mdujava
force-pushed
the
backend_usage_cleanup
branch
from
85d6ebf to
ff6ea3b
Compare
Member
|
in each of last test executed will hit ERROR: |
…ixture + required fixes in tests
mdujava
force-pushed
the
backend_usage_cleanup
branch
from
ff6ea3b to
2152e1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ixture + required fixes in tests