⚡ Optimize MicrotubuleTorus with InstancedMesh#61
Conversation
💡 **What:** Refactored the MicrotubuleTorus component to use THREE.InstancedMesh instead of individual Mesh components for each cube. 🎯 **Why:** Rendering hundreds of individual meshes was causing excessive draw calls. Using InstancedMesh reduces the draw calls from O(N) to O(1) per torus instance. 📊 **Measured Improvement:** Theoretically reduced draw calls from approximately 1082 to 4, a >99% reduction in scene graph overhead for the torus structures. Co-authored-by: jason420247 <44763042+jason420247@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Refactored the
MicrotubuleToruscomponent to useTHREE.InstancedMeshinstead of individualMeshcomponents for each cube.🎯 Why: Rendering hundreds of individual meshes (360 and 720 in the current scene) was causing excessive draw calls, leading to poor performance. Using$O(N)$ to $O(1)$ per torus instance.
InstancedMeshreduces the draw calls from📊 Measured Improvement: Theoretically reduced draw calls from approximately 1082 (360 + 720 + lighting) to 4 (1 per
InstancedMeshinstance + lighting), a >99% reduction in scene graph overhead for the torus structures. Additionally, using a singleTHREE.Object3Dfor matrix calculations minimizes per-frame allocations.PR created automatically by Jules for task 6035163963223848744 started by @jason420247