[UPLUS-125] SMS 제목 null처리 삭제

[arlen02-01]

🎫 지라 티켓

uplus-125

---

✅ 작업 사항

SMS 제목 null처리 삭제

---

📋 체크리스트

• 코드가 정상적으로 빌드됩니다.
• 관련 테스트 코드를 작성했습니다.
• 기존 테스트가 모두 통과합니다.
• 코드 스타일(Spotless, Checkstyle)을 준수합니다.

---

⌨ 기타

[gemini-code-assist]

Summary of Changes

Hello @arlen02-01, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the handling of notification subjects within the TemplateVersionService. It removes a specific normalization logic that previously forced SMS notification subjects to be null. By eliminating the normalizeSubject method, the system now directly utilizes the subject provided in the request for all channels, simplifying the subject management process.

Highlights

• Subject Normalization Removal: The normalizeSubject private method, which previously set the subject to null specifically for SMS channels, has been removed from TemplateVersionService.
• Direct Subject Usage: The createVersion and updateVersion methods in TemplateVersionService now directly use the subject provided in the request (request.subject()) for all channels, eliminating channel-specific subject normalization.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

이 PR은 normalizeSubject 메서드와 그 사용 부분을 제거합니다. 이 메서드는 TemplateVersion 엔티티의 subject 필드에 있는 // Email Only 주석으로 보아, SMS 템플릿에는 제목이 없어야 한다는 비즈니스 규칙을 강제하는 역할을 했던 것으로 보입니다. 이 로직을 제거하면 의도치 않게 SMS 템플릿에 제목이 저장될 수 있으며, 이는 데이터 불일치나 다른 시스템 부분에서 예기치 않은 동작을 유발할 수 있습니다. 리뷰 댓글에서는 이 중요한 로직을 복원하기 위한 구체적인 코드 수정안을 제시했습니다.

[github-actions]

SonarQube Quality Summary (Community)

✅ Quality Gate PASSED

Branch: feat/UPLUS-125
Compared to: default branch

Issues

• 🐞 Bugs: 0
• 🔐 Vulnerabilities: 2
• 📎 Code Smells: 50

Measures

• Coverage: 0%
• Duplication: 0%

🔗 Dashboard: https://sonarqube.swthewhite.store/dashboard?id=api-core&branch=feat/UPLUS-125

Generated automatically by GitHub Actions.

[k0081915]

고생하셨습니다