Skip to content

[UPLUS-132] 초기 데이터 삭제#1

Merged
swthewhite merged 4 commits into
developfrom
feat/UPLUS-132
Jan 26, 2026
Merged

[UPLUS-132] 초기 데이터 삭제#1
swthewhite merged 4 commits into
developfrom
feat/UPLUS-132

Conversation

@k0081915
Copy link
Copy Markdown
Member

@k0081915 k0081915 commented Jan 26, 2026

🍀 이슈 번호

  • #이슈번호
    UPLUS-132

✅ 작업 사항

  • 초기 데이터 삭제

📋 체크리스트

  • 코드가 정상적으로 빌드됩니다.
  • 관련 테스트 코드를 작성했습니다.
  • 기존 테스트가 모두 통과합니다.
  • 코드 스타일(Spotless, Checkstyle)을 준수합니다.

⌨ 기타

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @k0081915, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 풀 리퀘스트는 더 이상 필요 없는 초기 목 데이터를 제거하여 시스템의 불필요한 초기화 과정을 없애고, 이메일 청구서 템플릿의 유연성을 높여 상세 내역을 보다 구조적으로 표시할 수 있도록 개선합니다.

Highlights

  • 초기 목(Mock) 데이터 삭제: 애플리케이션 시작 시 목 데이터를 생성하던 MockDataInit.java 파일이 제거되었습니다.
  • 이메일 템플릿 개선: email.html에서 '결제 방법' 필드가 삭제되었으며, 청구 상세 내역을 그룹화하여 표시할 수 있도록 렌더링 로직이 업데이트되었습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이 PR은 애플리케이션 시작 시 목 데이터를 생성하던 MockDataInit 클래스를 삭제하는 것을 주요 내용으로 하고 있습니다. 이와 함께 이메일 템플릿(email.html)도 일부 수정되었습니다. 전반적으로 PR의 목적에 맞게 변경이 잘 이루어졌습니다. 한 가지, 이메일 템플릿에서 Thymeleaf의 Elvis 연산자를 사용하여 코드를 더 간결하게 만들 수 있는 부분을 제안합니다.

</td>

<td class="px-4 py-3 text-sm text-right"
th:classappend="${item.styleClass != null ? item.styleClass : 'text-gray-900'}"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thymeleaf의 Elvis 연산자(?:)를 사용하면 코드를 더 간결하게 만들 수 있습니다. A != null ? A : B 형태의 삼항 연산자를 A ?: B로 바꿀 수 있습니다.

Suggested change
th:classappend="${item.styleClass != null ? item.styleClass : 'text-gray-900'}"
th:classappend="${item.styleClass ?: 'text-gray-900'}"

@github-actions github-actions Bot added the size/L PR size: L label Jan 26, 2026
@github-actions
Copy link
Copy Markdown

SonarQube Quality Summary (Community)

Quality Gate PASSED

Branch: feat/UPLUS-132
Compared to: default branch

Issues

  • 🐞 Bugs: 0
  • 🔐 Vulnerabilities: 2
  • 📎 Code Smells: 49

Measures

  • Coverage: 0%
  • Duplication: 0%

🔗 Dashboard: https://sonarqube.swthewhite.store/dashboard?id=api-mock&branch=feat/UPLUS-132

Generated automatically by GitHub Actions.

@swthewhite swthewhite merged commit 8d41501 into develop Jan 26, 2026
6 of 8 checks passed
@swthewhite swthewhite deleted the feat/UPLUS-132 branch January 26, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L PR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants