QoL Resource tab with shortcuts #8115
Conversation
|
Any chance you could link resource names and resource paths? I recently needed to rename a folder for organization and as a result needed to go through and change the file paths and the names of the resources individually to match those file paths.... And I don't see much of a purpose for them having different names than their paths which they default to. Nonetheless these changes you have planned would already had a huge layer of convenience to that so great work! |
|
|
||
| const resourcesManager = project.getResourcesManager(); | ||
| const allNames = resourcesManager.getAllResourceNames().toJSArray(); | ||
| const currentIndex = allNames.indexOf(resource.getName()); |
There was a problem hiding this comment.
Use GetResourcePosition. No need for allNames
| const currentIndex = allNames.indexOf(resource.getName()); | ||
|
|
||
| let nextResourceName = null; | ||
| if (allNames.length > 1) { |
There was a problem hiding this comment.
Ideally we would expose Count in Bindings.idl for ResourcesContainer
| resourcesActionsMenuBuilder | ||
| } | ||
| /> | ||
| <div |
There was a problem hiding this comment.
Do we really need this container? Could we have a "onKeyDown" on the ResourcesList?
There was a problem hiding this comment.
Actually, do we really want to have a onKeyDown here? Could that be the ResourcesList that calls a props when up/down is called?
| } | ||
|
|
||
| const nextResource = resourcesManager.getResource(allNames[nextIndex]); | ||
| if (nextResource !== selectedResource) { |
|
|
||
| let nextIndex = 0; | ||
| if (selectedResource) { | ||
| const currentIndex = allNames.indexOf(selectedResource.getName()); |
There was a problem hiding this comment.
Same as the other, I think it would be worth exposing Count and using GetResourcePosition rather than everytime getting getAllResourceNames + calling to JSArray which creates useless copies of the list of names in memory.
|
|
||
| const keyboardShortcutsRef = React.useRef<KeyboardShortcuts>( | ||
| new KeyboardShortcuts({ | ||
| shortcutCallbacks: {}, |
There was a problem hiding this comment.
Add a comment explaining why you don't set onDelete and onRename here.
| ); | ||
| } | ||
|
|
||
| _onKeyDown = (event: KeyboardEvent) => { |
There was a problem hiding this comment.
As written in another comment, it could be the ResourcesList that take care of this. A good LLM model could probably find the best way to do it.
Add to the the resource list:
2.mp4