Skip to content

Package resources for web exports, reducing number of files for platforms like itch #8903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ClementPasteau wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Package resources for web exports, reducing number of files for platforms like itch #8903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Extensions/Spine/managers/pixi-spine-atlas-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,11 @@ namespace gdjs {
return imagesMap;
}, {});

// Note: "atlas" and "spine" resources are never put inside a resource
// pack at export (see `ResourcePackPlanner`), because `PIXI.Assets`
// decides which loader to use from the extension of the URL, and a
// `blob:` URL has none. Only the atlas pages, which are plain images
// given to the loader below as already-loaded textures, are packed.
const url = this._resourceLoader.getFullUrl(resource.file);
const alias = url;

Expand Down
1 change: 1 addition & 0 deletions GDJS/GDJS/IDE/ExporterHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,6 +1165,7 @@ void ExporterHelper::AddLibsInclude(bool pixiRenderers,
InsertUnique(includesFiles, "inputmanager.js");
InsertUnique(includesFiles, "jsonmanager.js");
InsertUnique(includesFiles, "Model3DManager.js");
InsertUnique(includesFiles, "ResourcePackManager.js");
InsertUnique(includesFiles, "ResourceLoader.js");
InsertUnique(includesFiles, "ResourceCache.js");
InsertUnique(includesFiles, "timemanager.js");
Expand Down
240 changes: 193 additions & 47 deletions GDJS/Runtime/ResourceLoader.ts
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading