Skip to content

fix: clamp lower bound of arcsin argument in get_apparent_wind() to prevent silent NaN #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhinavsudhik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: clamp lower bound of arcsin argument in get_apparent_wind() to prevent silent NaN #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion WeatherRoutingTool/ship/direct_power_boat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,12 +230,15 @@ def get_apparent_wind(self, true_wind_speed, true_wind_angle):
arg_arcsin = true_wind_speed[iang] * np.sin(np.radians(true_wind_angle[iang])) / apparent_wind_speed[
iang] * u.radian

# catch it if argument of arcsin is > 1 due to rounding issues but make sure to apply this only for
# catch it if argument of arcsin is > 1 and arcsin is < -1 due to rounding issues but make sure to apply this only for
# rounding issues
diff_to_one = arg_arcsin - 1 * u.radian
if diff_to_one > 0:
assert diff_to_one < 0.000001 * u.radian
arg_arcsin = 1 * u.radian
elif (diff_to_minus_one := arg_arcsin + 1 * u.radian) < 0:
assert abs(diff_to_minus_one) < 0.000001 * u.radian
arg_arcsin = -1 * u.radian

if apparent_wind_speed[iang] > 0:
apparent_wind_angle[iang] = np.arcsin(arg_arcsin.value) * u.radian
Expand Down