Fix session chat connection and UI model sync#37
Conversation
- Updates `useSessionLogs` hook to use the authenticated `WsClient` implementation via `createSessionChatClient` and `getWsTokenProvider()` instead of a raw `new WebSocket()`. This fixes the issue where the chat was silently failing to connect or send messages because it lacked auth headers. - Refactors `useSessionLogs` to listen to `WsClient` events natively. - Updates `WsClient` to dispatch synthetic `$open`, `$close`, and `$error` events so dependent hooks can track connection state accurately. - Adds two-way model syncing to `SessionChat` by introducing `modelOverride` and `onModelChange` props. This guarantees the model selection dropdown in `SessionDetailPage` stays synchronized with the underlying WebSocket's state. - Updates tests in `use-session-logs.test.ts` to mock the new `WsClient` dependency. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes the session page where the chat model selection in the UI would not sync properly with the actual chat window, and fixes the issue where the chat window would fail to send or receive messages because the unauthenticated WebSocket connection was being rejected by the backend API.
PR created automatically by Jules for task 1943862002864710423 started by @5rk7n