feat: Abstract Counter-Strike Sharp dependencies into services for fr… #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amework genericity This commit introduces a complete abstraction layer that: - Creates service interfaces (ICommandService, IConVarService, IGameStateService, etc.) - Implements concrete services that wrap Counter-Strike Sharp APIs - Refactors existing services to use these abstractions instead of direct API calls - Makes the framework generic and reusable across different game engines - Completes the GameStateService implementation with proper game state access methods The changes allow swapping out different frameworks by implementing the same service interfaces while maintaining all existing functionality.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Moved all Counter-Strike Sharp service abstractions from FiveStack.Services to FiveStack.CounterStrikeSharp.Services namespace to make them more modular and framework-agnostic. This allows for easier switching between frameworks in the future. - Created new FiveStack.CounterStrikeSharp.Services namespace - Moved all service interfaces and implementations to new namespace - Updated service registration in FiveStackServiceCollection.cs - Updated references in MatchManager.cs and GameServer.cs - Added README.md explaining the new structure
| { | ||
| public void CreateTimer(float time, Action callback, TimerFlags flags = TimerFlags.NONE) | ||
| { | ||
| new Timer(time, callback, flags); |
|
|
||
| public void CreateTimer(float time, Action<CCSPlayerController> callback, TimerFlags flags = TimerFlags.NONE) | ||
| { | ||
| new Timer(time, callback, flags); |
|
|
||
| public void CreateTimer(float time, Action<CCSPlayerController, string[]> callback, TimerFlags flags = TimerFlags.NONE) | ||
| { | ||
| new Timer(time, callback, flags); |
|
|
||
| public void CreateTimer(float time, Action<CCSPlayerController, string> callback, TimerFlags flags = TimerFlags.NONE) | ||
| { | ||
| new Timer(time, callback, flags); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…amework genericity
This commit introduces a complete abstraction layer that:
The changes allow swapping out different frameworks by implementing the same service interfaces while maintaining all existing functionality.